Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Link Tracking Protection to preserve headers #1965

Merged
merged 6 commits into from
Dec 22, 2023
Merged

Conversation

SlayterDev
Copy link
Contributor

@SlayterDev SlayterDev commented Dec 13, 2023

Task/Issue URL: https://app.asana.com/0/1163321984198618/1202368115363949/f
Tech Design URL:
CC:

Description:

Steps to test this PR:

  1. Clone https://github.com/duckduckgo/privacy-test-pages on brad/header-drop-test and serve the root directory locally
  2. Navigate to http://localhost:3000/privacy-protections/query-parameters/
  3. Ensure the tests pass ok
  4. Set a breakpoint in NavigationProtectionTabExtension.swift on Line 96
  5. Click a link in the test page
  6. In the debug console execute po request.allHTTPHeaders then po newRequest.allHTTPHeaders and ensure they are the same.

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@SlayterDev SlayterDev self-assigned this Dec 13, 2023
@SlayterDev SlayterDev marked this pull request as ready for review December 13, 2023 19:22
Copy link
Collaborator

@bwaresiak bwaresiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SlayterDev SlayterDev merged commit 67f9b83 into main Dec 22, 2023
14 checks passed
@SlayterDev SlayterDev deleted the brad/headers-fix branch December 22, 2023 15:30
samsymons added a commit that referenced this pull request Dec 24, 2023
# By Diego Rey Mendez (4) and others
# Via Fernando Bunn (2) and GitHub (1)
* main:
  Adds option + click support for our VPN menu to show some useful debu… (#2007)
  Update latency & tunnel failure monitor implementation (#2005)
  Prevents VPNSettings from reporting fake changes (#2004)
  Updates the copy for the VPN status bar item context menu (#2003)
  Implement subscription purchase (#1906)
  DBP: Add m_mac prefix to Pixels (#1952)
  Bump version to 1.69.0 (96)
  Update embedded files
  Update Link Tracking Protection to preserve headers (#1965)
  VPN menus improvements (#1979)
  Data Import ux redo (#1754)
  Fix: "SwiftLintPlugin" must be enabled before it can be used (#1987)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	DuckDuckGo/NavigationBar/View/NavigationBarViewController.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants